From 84564946fc9ae4c2f84283823a158a2f41ba28c8 Mon Sep 17 00:00:00 2001
From: Dominik Hebeler <dominik@hebeler.club>
Date: Fri, 13 Sep 2024 06:18:08 +0200
Subject: [PATCH] remove oncancel for card payments as it is called without
 need by paypal sdk

---
 pass/resources/js/checkout_paypal.js | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/pass/resources/js/checkout_paypal.js b/pass/resources/js/checkout_paypal.js
index a609500..2fa7e03 100644
--- a/pass/resources/js/checkout_paypal.js
+++ b/pass/resources/js/checkout_paypal.js
@@ -119,10 +119,12 @@ function get_paypal_checkout_data(funding_source) {
       cancelPayment(
         document.getElementById("paypal-checkout").dataset.payment_reference_id
       ),
-    onError: (err) =>
-      cancelPayment(
+    onError: (err) => {
+      console.error(err);
+      return cancelPayment(
         document.getElementById("paypal-checkout").dataset.payment_reference_id
-      ),
+      );
+    },
     onApprove: () => {
       let checkout_paypal_capture_order_url =
         document.querySelector(
@@ -181,6 +183,9 @@ function get_paypal_checkout_data(funding_source) {
   if (funding_source) {
     checkout_data.fundingSource = funding_source;
   }
+  if (funding_source == "card") {
+    delete checkout_data.onCancel;
+  }
   return checkout_data;
 }
 
-- 
GitLab