From d246e2df75ea0884654f8b82bde65869051eacc2 Mon Sep 17 00:00:00 2001 From: Dominik Pfennig <dominik@suma-ev.de> Date: Tue, 12 Jul 2016 09:59:32 +0200 Subject: [PATCH] Bug behoben, bei dem eine leere Wikipedia Quicktip Response nicht ausgewertet werden konnte --- app/Http/Controllers/MetaGerSearch.php | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/app/Http/Controllers/MetaGerSearch.php b/app/Http/Controllers/MetaGerSearch.php index 553332b4f..48a24e206 100644 --- a/app/Http/Controllers/MetaGerSearch.php +++ b/app/Http/Controllers/MetaGerSearch.php @@ -85,17 +85,20 @@ class MetaGerSearch extends Controller $quicktips = []; $url = "http://de.wikipedia.org/w/api.php?action=query&titles=".urlencode(implode("_",array_diff(explode(" ",$q),array("wikipedia"))))."&prop=info|extracts|categories&inprop=url|displaytitle&exintro&exsentences=3&format=json"; $decodedResponse = json_decode($this->get($url), true); - foreach($decodedResponse["query"]["pages"] as $result) + if( isset($decodedResponse["query"]["pages"]) ) { - if( isset($result['displaytitle']) && isset($result['fullurl']) && isset($result['extract']) ) + foreach($decodedResponse["query"]["pages"] as $result) { - $quicktip = []; - $quicktip["title"] = $result['displaytitle']; - $quicktip["URL"] = $result['fullurl']; - $quicktip["descr"] = strip_tags($result['extract']); - $quicktip['gefVon'] = "aus <a href=\"https://de.wikipedia.org\" target=\"_blank\">Wikipedia, der freien Enzyklopädie</a>"; - - $quicktips[] = $quicktip; + if( isset($result['displaytitle']) && isset($result['fullurl']) && isset($result['extract']) ) + { + $quicktip = []; + $quicktip["title"] = $result['displaytitle']; + $quicktip["URL"] = $result['fullurl']; + $quicktip["descr"] = strip_tags($result['extract']); + $quicktip['gefVon'] = "aus <a href=\"https://de.wikipedia.org\" target=\"_blank\">Wikipedia, der freien Enzyklopädie</a>"; + + $quicktips[] = $quicktip; + } } } $mquicktips = array_merge($mquicktips, $quicktips); -- GitLab