From 90447663a186ad10b460159f940ed9c7cdef1593 Mon Sep 17 00:00:00 2001
From: Dominik Hebeler <dominik@suma-ev.de>
Date: Thu, 15 Sep 2022 14:28:10 +0200
Subject: [PATCH] fixed page team test
---
metager/lang/.translation_io | 2 +-
metager/lang/de/team.php | 2 +-
metager/lang/en/team.php | 1 +
metager/lang/es/team.php | 1 +
metager/resources/views/team/team.blade.php | 2 +-
metager/tests/Browser/Pages/Team.php | 23 ++++++++++-----------
metager/tests/Browser/StaticPagesTest.php | 4 ++--
7 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/metager/lang/.translation_io b/metager/lang/.translation_io
index 0a979207e..23c18d7b7 100644
--- a/metager/lang/.translation_io
+++ b/metager/lang/.translation_io
@@ -1 +1 @@
-{"timestamp":1663244394}
\ No newline at end of file
+{"timestamp":1663244717}
\ No newline at end of file
diff --git a/metager/lang/de/team.php b/metager/lang/de/team.php
index 19f91283f..73baad03a 100644
--- a/metager/lang/de/team.php
+++ b/metager/lang/de/team.php
@@ -2,7 +2,7 @@
return [
'role.0' => 'geschäftsführender Vorstand',
- 'role.1' => 'Vorstand',
+ 'role.1.0' => 'Vorstand',
'role.1.1' => 'Vorständin',
'role.2' => 'Jugendschutzbeauftragte',
'role.3' => 'Pressereferentin',
diff --git a/metager/lang/en/team.php b/metager/lang/en/team.php
index a4eb18af7..a3918632d 100644
--- a/metager/lang/en/team.php
+++ b/metager/lang/en/team.php
@@ -4,6 +4,7 @@ return [
0 => 'CEO',
1 => [
1 => 'executive',
+ 0 => 'executive',
],
2 => 'Youth protection commissioner',
3 => 'press secretary',
diff --git a/metager/lang/es/team.php b/metager/lang/es/team.php
index 087954c48..c3e7232cc 100644
--- a/metager/lang/es/team.php
+++ b/metager/lang/es/team.php
@@ -4,6 +4,7 @@ return [
0 => 'Director ejecutivo [CEO]',
1 => [
1 => 'la junta directiva',
+ 0 => 'la junta directiva',
],
2 => 'Moderar y protección de menores',
3 => 'Revistar la prensa',
diff --git a/metager/resources/views/team/team.blade.php b/metager/resources/views/team/team.blade.php
index a1dffbe86..7ea4e1daf 100644
--- a/metager/resources/views/team/team.blade.php
+++ b/metager/resources/views/team/team.blade.php
@@ -11,7 +11,7 @@
<p>Hebeler, Dominik - {!! trans('team.role.0') !!}
</li>
<li>
- <p>Riel, Carsten - {!! trans('team.role.1') !!} & {!! trans('team.role.7') !!}
+ <p>Riel, Carsten - {!! trans('team.role.1.0') !!} & {!! trans('team.role.7') !!}
</li>
<li>
<p>Branz, Manuela - {!! trans('team.role.1.1') !!} & {!! trans('team.role.3') !!}
diff --git a/metager/tests/Browser/Pages/Team.php b/metager/tests/Browser/Pages/Team.php
index 8077b875b..c46e21af7 100644
--- a/metager/tests/Browser/Pages/Team.php
+++ b/metager/tests/Browser/Pages/Team.php
@@ -3,6 +3,8 @@
namespace Tests\Browser\Pages;
use Laravel\Dusk\Browser;
+use Laravel\Dusk\Page;
+use LaravelLocalization;
class Team extends Page
{
@@ -11,9 +13,9 @@ class Team extends Page
*
* @return string
*/
- public function url()
+ public function url($locale = null)
{
- return '/team';
+ return LaravelLocalization::getLocalizedUrl($locale, "/team");
}
/**
@@ -24,17 +26,14 @@ class Team extends Page
*/
public function assert(Browser $browser)
{
- $browser->assertPathIs($this->url())
- ->waitForText("geschäftsführender Vorstand")
- ->assertTitle("Team - MetaGer")
- ->switchLanguage("English")
- ->waitForText("CEO")
- ->assertTitle("Team - MetaGer")
- ->switchLanguage("Español")
- ->waitForText("Director ejecutivo [CEO]")
- ->assertTitle("Nuestra gente - MetaGer")
- ->switchLanguage("Deutsch");
+ foreach (LaravelLocalization::getSupportedLocales() as $locale => $locale_data) {
+ $url = $this->url($locale);
+ $lang = \preg_replace("/^([a-zA-Z]+)-.*/", "$1", $locale);
+ $browser->visit($url)
+ ->waitForText(trans("team.role.0", [], $lang))
+ ->assertTitle(trans("titles.team", [], $lang));
+ }
}
/**
diff --git a/metager/tests/Browser/StaticPagesTest.php b/metager/tests/Browser/StaticPagesTest.php
index 22ce388d4..7dc7cf2a5 100644
--- a/metager/tests/Browser/StaticPagesTest.php
+++ b/metager/tests/Browser/StaticPagesTest.php
@@ -133,7 +133,7 @@ class StaticPagesTest extends DuskTestCase
->on(new Spende);
});
}
- /*
+
public function testTeam()
{
// Team
@@ -147,7 +147,7 @@ class StaticPagesTest extends DuskTestCase
->on(new Team);
});
}
-
+/*
public function testWidget()
{
// Widget
--
GitLab